Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable Callcontroller tests #529

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Reenable Callcontroller tests #529

merged 4 commits into from
Sep 19, 2024

Conversation

ipavlidakis
Copy link
Collaborator

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Sep 18, 2024
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 18, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 18, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 18, 2024 19:07
@github-actions GitHub Actions
Copy link

1 Error
🚫 Please use more than one word.
d4b3ebb
1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 18, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.85 MB +455 KB 🟡
StreamVideoSwiftUI 2.18 MB 2.18 MB -2 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -2 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the reconnection-v2/reenable-callcontroller-tests branch 3 times, most recently from 30a18b7 to 2f5d7b5 Compare September 18, 2024 22:35
@ipavlidakis ipavlidakis force-pushed the reconnection-v2/reenable-callcontroller-tests branch from 2f5d7b5 to 546155b Compare September 18, 2024 22:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
109 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

martinmitrevski
martinmitrevski approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ipavlidakis ipavlidakis merged commit 0f62fc3 into feature/reconnection-v2 Sep 19, 2024
12 of 13 checks passed
@ipavlidakis ipavlidakis deleted the reconnection-v2/reenable-callcontroller-tests branch September 19, 2024 08:18
ipavlidakis added a commit that referenced this pull request Sep 19, 2024
@ipavlidakis
Reenable Callcontroller tests (#529)
c094422
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
Reenable Callcontroller tests (#529)
4682cd0
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
Reenable Callcontroller tests (#529)
c772f60
ipavlidakis added a commit that referenced this pull request Sep 26, 2024
@ipavlidakis
Reenable Callcontroller tests (#529)
df11faa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski